Code review comment for lp:~vishvananda/nova/ha-net

Hmm, this could be a bug. It is supposed to set_network_host in the allocate_for_instance call. I must have missed one of the code paths. Will check.

Vish

On Jul 15, 2011, at 11:33 PM, Koji Iida wrote:

> Review: Needs Information
> I have a question.
>
> I can't boot a instance under VlanManager and multi_host set to false.
>
> 2011-07-16 13:21:37,094 DEBUG nova.network.manager [H40YHKSORHMMV047X7BB admin admin] floating IP allocation for instance |1| from (pid=9900) allocate_for_instance /opt2/ha-net/nova/network/manager.py:195
> 2011-07-16 13:21:37,094 DEBUG nova.network.manager [H40YHKSORHMMV047X7BB admin admin] network allocations for instance 1 from (pid=9900) allocate_for_instance /opt2/ha-net/nova/network/manager.py:378
> 2011-07-16 13:21:37,102 ERROR nova [-] Exception during message handling
> (nova): TRACE: Traceback (most recent call last):
> (nova): TRACE: File "/opt2/ha-net/nova/rpc.py", line 232, in _process_data
> (nova): TRACE: rval = node_func(context=ctxt, **node_args)
> (nova): TRACE: File "/opt2/ha-net/nova/network/manager.py", line 199, in allocate_for_instance
> (nova): TRACE: ips = super(FloatingIP, self).allocate_for_instance(context, **kwargs)
> (nova): TRACE: File "/opt2/ha-net/nova/network/manager.py", line 380, in allocate_for_instance
> (nova): TRACE: project_id)
> (nova): TRACE: File "/opt2/ha-net/nova/network/manager.py", line 847, in _get_networks_for_instance
> (nova): TRACE: return self.db.project_get_networks(context, project_id)
> (nova): TRACE: File "/opt2/ha-net/nova/db/api.py", line 1234, in project_get_networks
> (nova): TRACE: return IMPL.project_get_networks(context, project_id, associate)
> (nova): TRACE: File "/opt2/ha-net/nova/db/sqlalchemy/api.py", line 115, in wrapper
> (nova): TRACE: return f(*args, **kwargs)
> (nova): TRACE: File "/opt2/ha-net/nova/db/sqlalchemy/api.py", line 2749, in project_get_networks
> (nova): TRACE: return [network_associate(context, project_id)]
> (nova): TRACE: File "/opt2/ha-net/nova/db/sqlalchemy/api.py", line 97, in wrapper
> (nova): TRACE: return f(*args, **kwargs)
> (nova): TRACE: File "/opt2/ha-net/nova/db/sqlalchemy/api.py", line 1516, in network_associate
> (nova): TRACE: raise db.NoMoreNetworks()
> (nova): TRACE: NoMoreNetworks: None
> (nova): TRACE:
>
>
> 615 - # setup any new networks which have been created
> 616 - self.set_network_hosts(context)
>
> set_network_hosts() is removed from periodic_tasks.
> Are there any other mechanisms to allocate host to network?
>
>
>
>
> --
> https://code.launchpad.net/~vishvananda/nova/ha-net/+merge/67078
> You are the owner of lp:~vishvananda/nova/ha-net.