Code review comment for lp:~vishvananda/nova/fix-swap-manage

Revision history for this message
Mark McLoughlin (markmc) wrote :

lgtm

There doesn't seem to be a lot of places where the semantics are clear, except e.g. libvirt/connection.py:

  swap_mb = inst_type['swap']

Updating the docs for the --swap arg to 'nova-manage instance_type create' would help

review: Approve

« Back to merge proposal