Merge lp:~vishvananda/nova/dhcplease-flags into lp:~hudson-openstack/nova/trunk

[Joshua McKenty]

Fixes to dhcp lease code to use a flagfile

Already reviewed against soren's branch.

[Joshua McKenty (joshua-mckenty)]

Reviewed this against soren's branch already.

review: Approve

[Monty Taylor (mordred)]

Needs to be merged with trunk. There is currently an unresolved merge conflict.

review: Needs Fixing

[Joshua McKenty (joshua-mckenty)]

> Needs to be merged with trunk. There is currently an unresolved merge
> conflict.

Looks resolved to me, am I missing something?

[Soren Hansen (soren)]

When attempting the merge, I get a conflict in nova/compute/linux_net.py. Fix that, and I'll approve the merge.

[lp:~vishvananda/nova/dhcplease-flags]

143. By Vish Ishaya on 2010-07-19

merged trunk

[Vish Ishaya (vishvananda)]

fixed again

=== renamed file 'bin/dhcpleasor.py' => 'bin/nova-dhcpbridge'
--- bin/dhcpleasor.py	2010-07-15 23:13:48 +0000
+++ bin/nova-dhcpbridge	2010-07-19 19:46:42 +0000
@@ -18,23 +18,27 @@
 #    under the License.
 
 """
-dhcpleasor.py
+nova-dhcpbridge
 
 Handle lease database updates from DHCP servers.
 """
 
+import logging
+import os
 import sys
-import os
-import logging
+
+#TODO(joshua): there is concern that the user dnsmasq runs under will not
+#              have nova in the path. This should be verified and if it is
+#              not true the ugly line below can be removed
 sys.path.append(os.path.abspath(os.path.join(__file__, "../../")))
 
-logging.debug(sys.path)
-import getopt
-from os import environ
+from nova import flags
 from nova import rpc
-from nova import flags
+from nova import utils
 from nova.compute import linux_net
 from nova.compute import network
+
+
 FLAGS = flags.FLAGS
 
 
@@ -63,11 +67,12 @@
     return res
 
 
-def main(argv=None):
-    if argv is None:
-        argv = sys.argv
-    interface = environ.get('DNSMASQ_INTERFACE', 'br0')
-    if int(environ.get('TESTING', '0')):
+def main():
+    flagfile = os.environ.get('FLAGFILE', FLAGS.dhcpbridge_flagfile)
+    utils.default_flagfile(flagfile)
+    argv = FLAGS(sys.argv)
+    interface = os.environ.get('DNSMASQ_INTERFACE', 'br0')
+    if int(os.environ.get('TESTING', '0')):
         FLAGS.fake_rabbit = True
         FLAGS.redis_db = 8
         FLAGS.network_size = 32
 
=== modified file 'debian/nova-api.conf'
--- debian/nova-api.conf	2010-07-05 13:37:52 +0000
+++ debian/nova-api.conf	2010-07-19 19:46:42 +0000
@@ -1,5 +1,6 @@
 --daemonize=1
 --ca_path=/var/lib/nova/CA
 --keys_path=/var/lib/nova/keys
+--networks_path=/var/lib/nova/networks
+--dhcpbridge_flagfile=/etc/nova/nova-dhcpbridge.conf
 --fake_users=1
---datastore_path=/var/lib/nova/keeper
 
=== modified file 'debian/nova-api.install'
--- debian/nova-api.install	2010-07-12 15:39:01 +0000
+++ debian/nova-api.install	2010-07-19 19:46:42 +0000
@@ -1,2 +1,3 @@
 bin/nova-api usr/bin
 debian/nova-api.conf etc/nova
+debian/nova-dhcpbridge.conf etc/nova
 
=== modified file 'debian/nova-compute.conf'
--- debian/nova-compute.conf	2010-07-14 23:48:05 +0000
+++ debian/nova-compute.conf	2010-07-19 19:46:42 +0000
@@ -1,8 +1,6 @@
 --ca_path=/var/lib/nova/CA
 --keys_path=/var/lib/nova/keys
---datastore_path=/var/lib/nova/keeper
 --instances_path=/var/lib/nova/instances
---networks_path=/var/lib/nova/networks
 --simple_network_template=/usr/share/nova/interfaces.template
 --libvirt_xml_template=/usr/share/nova/libvirt.xml.template
 --vpn_client_template=/usr/share/nova/client.ovpn.template
 
=== added file 'debian/nova-dhcp.conf'
--- debian/nova-dhcp.conf	1970-01-01 00:00:00 +0000
+++ debian/nova-dhcp.conf	2010-07-19 19:46:42 +0000
@@ -0,0 +1,2 @@
+--networks_path=/var/lib/nova/networks
+--fake_users=1
 
=== modified file 'debian/nova-objectstore.conf'
--- debian/nova-objectstore.conf	2010-07-05 13:37:52 +0000
+++ debian/nova-objectstore.conf	2010-07-19 19:46:42 +0000
@@ -1,7 +1,6 @@
 --daemonize=1
 --ca_path=/var/lib/nova/CA
 --keys_path=/var/lib/nova/keys
---datastore_path=/var/lib/nova/keeper
 --fake_users=1
 --images_path=/var/lib/nova/images
 --buckets_path=/var/lib/nova/buckets
 
=== modified file 'debian/nova-volume.conf'
--- debian/nova-volume.conf	2010-07-05 13:37:52 +0000
+++ debian/nova-volume.conf	2010-07-19 19:46:42 +0000
@@ -1,7 +1,6 @@
 --daemonize=1
 --ca_path=/var/lib/nova/CA
 --keys_path=/var/lib/nova/keys
---datastore_path=/var/lib/nova/keeper
 --fake_users=1
 --images_path=/var/lib/nova/images
 --buckets_path=/var/lib/nova/buckets
 
=== modified file 'nova/compute/linux_net.py'
--- nova/compute/linux_net.py	2010-07-18 17:02:04 +0000
+++ nova/compute/linux_net.py	2010-07-19 19:46:42 +0000
@@ -28,12 +28,16 @@
 from nova import flags
 FLAGS=flags.FLAGS
 
-def execute(cmd):
+flags.DEFINE_string('dhcpbridge_flagfile',
+                    '/etc/nova-dhcpbridge.conf',
+                    'location of flagfile for dhcpbridge')
+
+def execute(cmd, addl_env=None):
     if FLAGS.fake_network:
         logging.debug("FAKE NET: %s" % cmd)
         return "fake", 0
     else:
-        return utils.execute(cmd)
+        return utils.execute(cmd, addl_env=addl_env)
 
 def runthis(desc, cmd):
     if FLAGS.fake_network:
@@ -61,7 +65,7 @@
 
 def bind_public_ip(ip, interface):
     runthis("Binding IP to interface: %s", "sudo ip addr add %s dev %s" % (ip, interface))
-    
+
 def unbind_public_ip(ip, interface):
     runthis("Binding IP to interface: %s", "sudo ip addr del %s dev %s" % (ip, interface))
 
@@ -99,7 +103,7 @@
         ' --except-interface=lo',
         ' --dhcp-range=%s,static,600s' % (net.dhcp_range_start),
         ' --dhcp-hostsfile=%s' % dhcp_file(net['vlan'], 'conf'),
-        ' --dhcp-script=%s' % bin_file('dhcpleasor.py'),
+        ' --dhcp-script=%s' % bin_file('nova-dhcpbridge'),
         ' --leasefile-ro']
     return ''.join(cmd)
 
@@ -139,7 +143,9 @@
     if os.path.exists(lease_file):
         os.unlink(lease_file)
 
-    Popen(dnsmasq_cmd(network).split(" "))
+    # FLAGFILE in env
+    env = {'FLAGFILE' : FLAGS.dhcpbridge_flagfile}
+    execute(dnsmasq_cmd(network), addl_env=env)
 
 def stop_dnsmasq(network):
     """ stops the dnsmasq instance for a given network """
 
=== modified file 'nova/compute/network.py'
--- nova/compute/network.py	2010-07-16 22:42:40 +0000
+++ nova/compute/network.py	2010-07-19 19:46:42 +0000
@@ -251,7 +251,7 @@
         raise compute_exception.NoMoreAddresses("Project %s with network %s" %
                                                 (project_id, str(self.network)))
 
-    def lease_ip(self, ip_str):    
+    def lease_ip(self, ip_str):
         logging.debug("Leasing allocated IP %s" % (ip_str))
 
     def release_ip(self, ip_str):
@@ -566,10 +566,10 @@
 
 def deallocate_ip(address):
     return get_network_by_address(address).deallocate_ip(address)
-    
+
 def release_ip(address):
     return get_network_by_address(address).release_ip(address)
-    
+
 def lease_ip(address):
     return get_network_by_address(address).lease_ip(address)
 
 
=== modified file 'nova/tests/network_unittest.py'
--- nova/tests/network_unittest.py	2010-07-15 23:13:48 +0000
+++ nova/tests/network_unittest.py	2010-07-19 19:46:42 +0000
@@ -19,16 +19,15 @@
 import IPy
 import os
 import logging
-import unittest
 
 from nova import flags
 from nova import test
-from nova import exception
+from nova import utils
+from nova.auth import users
+from nova.compute import network
 from nova.compute.exception import NoMoreAddresses
-from nova.compute import network
-from nova.auth import users
-from nova import utils
 
+FLAGS = flags.FLAGS
 
 class NetworkTestCase(test.TrialTestCase):
     def setUp(self):
@@ -180,14 +179,20 @@
 
 class FakeDNSMasq(object):
     def issue_ip(self, mac, ip, hostname, interface):
-        cmd = "%s add %s %s %s" % (binpath('dhcpleasor.py'), mac, ip, hostname)
-        env = {'DNSMASQ_INTERFACE': interface, 'TESTING' : '1'}
+        cmd = "%s add %s %s %s" % (binpath('nova-dhcpbridge'),
+                                   mac, ip, hostname)
+        env = {'DNSMASQ_INTERFACE': interface,
+               'TESTING' : '1',
+               'FLAGFILE' : FLAGS.dhcpbridge_flagfile}
         (out, err) = utils.execute(cmd, addl_env=env)
         logging.debug("ISSUE_IP: %s, %s " % (out, err))
 
     def release_ip(self, mac, ip, hostname, interface):
-        cmd = "%s del %s %s %s" % (binpath('dhcpleasor.py'), mac, ip, hostname)
-        env = {'DNSMASQ_INTERFACE': interface, 'TESTING' : '1'}
+        cmd = "%s del %s %s %s" % (binpath('nova-dhcpbridge'),
+                                   mac, ip, hostname)
+        env = {'DNSMASQ_INTERFACE': interface,
+               'TESTING' : '1',
+               'FLAGFILE' : FLAGS.dhcpbridge_flagfile}
         (out, err) = utils.execute(cmd, addl_env=env)
         logging.debug("RELEASE_IP: %s, %s " % (out, err))