Merge lp:~vishvananda/nova/bug782364-ms into lp:~hudson-openstack/nova/milestone-proposed

Proposed by Vish Ishaya
Status: Merged
Approved by: Vish Ishaya
Approved revision: 1514
Merged at revision: 1188
Proposed branch: lp:~vishvananda/nova/bug782364-ms
Merge into: lp:~hudson-openstack/nova/milestone-proposed
Diff against target: 34 lines (+10/-0)
1 file modified
nova/network/linux_net.py (+10/-0)
To merge this branch: bzr merge lp:~vishvananda/nova/bug782364-ms
Reviewer Review Type Date Requested Status
OpenStack release team Pending
Review via email: mp+76118@code.launchpad.net

Description of the change

backport of arping for floating ips.

To post a comment you must log in.
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

The attempt to merge lp:~vishvananda/nova/bug782364-ms into lp:~hudson-openstack/nova/milestone-proposed failed. Below is the output from the failed tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'nova/network/linux_net.py'
--- nova/network/linux_net.py 2011-09-19 21:06:58 +0000
+++ nova/network/linux_net.py 2011-09-19 22:09:26 +0000
@@ -68,6 +68,8 @@
68 'Driver used to create ethernet devices.')68 'Driver used to create ethernet devices.')
69flags.DEFINE_string('linuxnet_ovs_integration_bridge',69flags.DEFINE_string('linuxnet_ovs_integration_bridge',
70 'br-int', 'Name of Open vSwitch bridge used with linuxnet')70 'br-int', 'Name of Open vSwitch bridge used with linuxnet')
71flags.DEFINE_bool('send_arp_for_ha', False,
72 'send gratuitous ARPs for HA setup')
71flags.DEFINE_bool('use_single_default_gateway',73flags.DEFINE_bool('use_single_default_gateway',
72 False, 'Use single default gateway. Only first nic of vm'74 False, 'Use single default gateway. Only first nic of vm'
73 ' will get default gateway from dhcp server')75 ' will get default gateway from dhcp server')
@@ -407,6 +409,10 @@
407 _execute('ip', 'addr', 'add', floating_ip,409 _execute('ip', 'addr', 'add', floating_ip,
408 'dev', FLAGS.public_interface,410 'dev', FLAGS.public_interface,
409 run_as_root=True, check_exit_code=check_exit_code)411 run_as_root=True, check_exit_code=check_exit_code)
412 if FLAGS.send_arp_for_ha:
413 _execute('arping', '-U', floating_ip,
414 '-A', '-I', FLAGS.public_interface,
415 '-c', 1, run_as_root=True, check_exit_code=False)
410416
411417
412def unbind_floating_ip(floating_ip):418def unbind_floating_ip(floating_ip):
@@ -478,6 +484,10 @@
478 check_exit_code=False)484 check_exit_code=False)
479 if err and err != 'RTNETLINK answers: File exists\n':485 if err and err != 'RTNETLINK answers: File exists\n':
480 raise exception.Error('Failed to add ip: %s' % err)486 raise exception.Error('Failed to add ip: %s' % err)
487 if FLAGS.send_arp_for_ha:
488 _execute('arping', '-U', network_ref['gateway'],
489 '-A', '-I', dev,
490 '-c', 1, run_as_root=True, check_exit_code=False)
481 if(FLAGS.use_ipv6):491 if(FLAGS.use_ipv6):
482 _execute('ip', '-f', 'inet6', 'addr',492 _execute('ip', '-f', 'inet6', 'addr',
483 'change', network_ref['cidr_v6'],493 'change', network_ref['cidr_v6'],

Subscribers

People subscribed via source and target branches