Merge lp:~vishvananda/nova/bug782364-ms into lp:~hudson-openstack/nova/milestone-proposed

Proposed by Vish Ishaya
Status: Merged
Approved by: Vish Ishaya
Approved revision: 1514
Merged at revision: 1188
Proposed branch: lp:~vishvananda/nova/bug782364-ms
Merge into: lp:~hudson-openstack/nova/milestone-proposed
Diff against target: 34 lines (+10/-0)
1 file modified
nova/network/linux_net.py (+10/-0)
To merge this branch: bzr merge lp:~vishvananda/nova/bug782364-ms
Reviewer Review Type Date Requested Status
OpenStack release team Pending
Review via email: mp+76118@code.launchpad.net

Description of the change

backport of arping for floating ips.

To post a comment you must log in.
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

The attempt to merge lp:~vishvananda/nova/bug782364-ms into lp:~hudson-openstack/nova/milestone-proposed failed. Below is the output from the failed tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/network/linux_net.py'
2--- nova/network/linux_net.py 2011-09-19 21:06:58 +0000
3+++ nova/network/linux_net.py 2011-09-19 22:09:26 +0000
4@@ -68,6 +68,8 @@
5 'Driver used to create ethernet devices.')
6 flags.DEFINE_string('linuxnet_ovs_integration_bridge',
7 'br-int', 'Name of Open vSwitch bridge used with linuxnet')
8+flags.DEFINE_bool('send_arp_for_ha', False,
9+ 'send gratuitous ARPs for HA setup')
10 flags.DEFINE_bool('use_single_default_gateway',
11 False, 'Use single default gateway. Only first nic of vm'
12 ' will get default gateway from dhcp server')
13@@ -407,6 +409,10 @@
14 _execute('ip', 'addr', 'add', floating_ip,
15 'dev', FLAGS.public_interface,
16 run_as_root=True, check_exit_code=check_exit_code)
17+ if FLAGS.send_arp_for_ha:
18+ _execute('arping', '-U', floating_ip,
19+ '-A', '-I', FLAGS.public_interface,
20+ '-c', 1, run_as_root=True, check_exit_code=False)
21
22
23 def unbind_floating_ip(floating_ip):
24@@ -478,6 +484,10 @@
25 check_exit_code=False)
26 if err and err != 'RTNETLINK answers: File exists\n':
27 raise exception.Error('Failed to add ip: %s' % err)
28+ if FLAGS.send_arp_for_ha:
29+ _execute('arping', '-U', network_ref['gateway'],
30+ '-A', '-I', dev,
31+ '-c', 1, run_as_root=True, check_exit_code=False)
32 if(FLAGS.use_ipv6):
33 _execute('ip', '-f', 'inet6', 'addr',
34 'change', network_ref['cidr_v6'],

Subscribers

People subscribed via source and target branches