Code review comment for ~virtustom/ubuntu-docker-images/+git/utils:azurecr
Revision history for this message
| Sergio Durigan Junior (sergiodj) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks for the MP, Tomáš.
Overall this LGTM, but I'm leaving a comment about the changes you've made to the functions using trap. Let me know what you think.
I confess I haven't tested these changes, so I'm trusting your report saying that tests went fine.
Regarding the push-images.sh script, that's just a helper I wrote when we were creating the initial images. I haven't maintained it properly and it could even be deleted from the repo TBH.
Anyway, I will wait for your reply before giving my +1. Thanks.