Code review comment for lp:~vinod-khare/pithos/appindicator

Revision history for this message
Vinod Khare (vinod-khare) wrote :

> Can this share any code with the recently-merged notification area icon patch?
> Sorry to merge that just as you were about to submit...
>
> See http://bazaar.launchpad.net/~gtg/gtg/trunk/annotate/head:/GTG/plugins/noti
> fication_area/notification_area.py
> for an example of a notification area plugin that combines appindicator and
> the legacy notification area
>
> Then it can use the same enable/disable mechanism I implemented for the
> existing icon.
>
> Also, it looks like this branch sets the execute bit on every file in the
> repository. Is there anything you can do about this?

Yeah, just saw the merge, I'm pulling the changes to see if I can merge the two things.

« Back to merge proposal