Code review comment for lp:~vila/udd/analyze-log-imports

>>>>> John Arbash Meinel <email address hidden> writes:

<snip/>

    >> That's one exception to TDD to me: I don't think automated tests
    >> add value here because I have real data to play with, both from
    >> the past and more importantly, live data from the running
    >> importer. So it's already easy enough to catch errors and fix
    >> them.
    >>

    > You don't know if you are missing things running against the live
    > importer. (AFAIK.)

Just try it then, you'll know more ;)

I've tested this script for several days on the live importer and also
on some older logs while changing it. It makes a real difference in the
feedback compared to tail -F.

This script is meant to help and the added feature is far from life
critical (even for me who took the time to write it). There are
certainly other areas that need more testing, I'd prefer to focus on
them.

    >>
    >> It displays the distro, the release and the version that was imported, those aren't times.
    >>

    > The comment still doesn't add value, IMO.

I put it there as a reminder that the method is not name doesn't
represent the job done and explained so in more words in the cover
letter.

I'll gladly update this comment if you have a better way to express
that.