Code review comment for lp:~vila/udd/735477-kill-harder

Revision history for this message
James Westby (james-w) wrote :

On Mon, 21 Mar 2011 14:57:42 -0000, John A Meinel <email address hidden> wrote:
> Review: Approve
> It seems like this breaks the restart script, since any grace period
> is going to not have the service stopped before starting the next
> one. But the actual logic seems fine to me.

The stop call could use "--retry SOMENUMBER" with start-stop-daemon,
which would have it wait some time for the daemon to exit, and then kill
it after that, and wait some more. See the man page for details.

Thanks,

James

« Back to merge proposal