Code review comment for lp:~vila/udd/717109-create-import-jobs-backlog

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/11/2011 9:35 AM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/udd/717109-create-import-jobs-backlog into lp:udd.
>
> Requested reviews:
> Ubuntu Distributed Development Developers (udd)
> Related bugs:
> #717109 lp timeout when trying to start a package importer from scratch
> https://bugs.launchpad.net/bugs/717109
>
> For more details, see:
> https://code.launchpad.net/~vila/udd/717109-create-import-jobs-backlog/+merge/49406
>
> This fixes bug #717109 so we can re-start a package importer from scratch.
>
> This should be enough to seed the importer.
>
> Adding a command-line option may be a nice followup but I don't need it for now.

I know James approved this. But I did send this earlier:
As I mentioned on the bug, this is dangerous because it creates a window
where there can be packages that were uploaded but will never be seen.

The fact that future updates will cause us to go back and import them
means this shouldn't be a data-loss situation, but I'm uncomfortable
with it.

Apparently "status: needs_information" rejects the whole message.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1Vfc8ACgkQJdeBCYSNAAMcgwCffeI5c4Z5rZQ5HYncr9+qsZ2G
uq0AoKv5rmReLo3eUYmw5RpBS4GOz43P
=eFlx
-----END PGP SIGNATURE-----