Code review comment for lp:~vila/ubuntu-ci-services-itself/testy

On 12/06/2013 09:34 AM, Vincent Ladeuil wrote:
> + test_image(image_url, package_name) -> test_request_id

> +This ends the processing of a 'done' request and is sent to the 'Landing
> +Manager'.

> + done(test_request_id, status=[FAIL, SUCCESS], test_result, artifacts)

This introduces a new decision for us to make. In the
branch-source-builder we have something called a "progress_trigger". It
appears to be the same concept as your "test_request_id". So the first
decision is simply agreeing on a common name for this thing.

The thing where the branch-source-builder really differs is on who
creates progress_trigger. In its design, the caller passes this value.
In your design the implementation creates and returns the value. I don't
have a strong opinion. However, I suspect the branch-source-builder's
approach will be more HA friendly. eg, it can create this object and
persist it somehow for the service. If the calling service dies while
the request is being processed, its okay. The messages will get queued
up somewhere to be determined, and when the back-up service comes back
online it will know about this progress_trigger and be able to catch
back up with the queued responses.