Merge lp:~vila/ubuntu-ci-services-itself/reuse-payload into lp:ubuntu-ci-services-itself

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 304
Merged at revision: 304
Proposed branch: lp:~vila/ubuntu-ci-services-itself/reuse-payload
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 23 lines (+5/-1)
1 file modified
juju-deployer/deploy.py (+5/-1)
To merge this branch: bzr merge lp:~vila/ubuntu-ci-services-itself/reuse-payload
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+209279@code.launchpad.net

Commit message

Avoid uploading the ci-payload again when encountering deployment issues

Description of the change

It often takes several attempts to properly run ./juju-deployer/deploy.py until completion.

A significant portion of the time is spent uploading the payload, this gives a way to avoid it completely.

The long term solution would be to be more specific about what we upload but in the mean time, this addresses my current issue.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:304
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~vila/ubuntu-ci-services-itself/reuse-payload/+merge/209279/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/283/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/283/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

THANK YOU!!!!!

I was so frustrated about this issue yesterday. I was about to just comment out that snippet in my local branch. This is much better.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'juju-deployer/deploy.py'
--- juju-deployer/deploy.py 2014-02-28 09:25:47 +0000
+++ juju-deployer/deploy.py 2014-03-04 14:59:02 +0000
@@ -228,6 +228,10 @@
228 help='''Use the current tip of this payload branch for228 help='''Use the current tip of this payload branch for
229 the code-base rather than a tarball of the current229 the code-base rather than a tarball of the current
230 directory.''')230 directory.''')
231 parser.add_argument('--reuse-payload', action='store_true',
232 help='''Use the already uploaded payload for
233 the code-base rather than a tarball of the current
234 directory. Use at your own risk.''')
231 parser.add_argument('specific', metavar='<config.yaml>', nargs='*',235 parser.add_argument('specific', metavar='<config.yaml>', nargs='*',
232 help='Use a specific list of juju-deployer configs.')236 help='Use a specific list of juju-deployer configs.')
233237
@@ -250,7 +254,7 @@
250 working_dir = os.path.join(temp_dir, 'deployer')254 working_dir = os.path.join(temp_dir, 'deployer')
251 shutil.copytree(deployer_dir, working_dir)255 shutil.copytree(deployer_dir, working_dir)
252256
253 if not args.branch_payload:257 if not args.branch_payload and not args.reuse_payload:
254 setup_swift()258 setup_swift()
255259
256 # Create .yaml files from .yaml.tmpl files.260 # Create .yaml files from .yaml.tmpl files.

Subscribers

People subscribed via source and target branches