Merge lp:~vila/testtools/trunk into lp:~testtools-committers/testtools/trunk

Proposed by Vincent Ladeuil
Status: Merged
Merged at revision: 295
Proposed branch: lp:~vila/testtools/trunk
Merge into: lp:~testtools-committers/testtools/trunk
Diff against target: 25 lines (+2/-2)
2 files modified
doc/for-test-authors.rst (+1/-1)
testtools/run.py (+1/-1)
To merge this branch: bzr merge lp:~vila/testtools/trunk
Reviewer Review Type Date Requested Status
Jonathan Lange Approve
Review via email: mp+136915@code.launchpad.net

Description of the change

Two small fixes here.

1) The doc for test authors has a typo.

2) While trying to reuse testtools.run.TestProgram I ran into the case where
   I didn't provide a testRunner argument. The default handling seems to have
   been imported from python where 'runner' is defined. That's the case here so
   I went with what seems to be a sane default.

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/for-test-authors.rst'
--- doc/for-test-authors.rst 2012-01-29 14:08:39 +0000
+++ doc/for-test-authors.rst 2012-11-29 11:44:24 +0000
@@ -432,7 +432,7 @@
432 def test_keys_equal(self):432 def test_keys_equal(self):
433 x = {'a': 1, 'b': 2}433 x = {'a': 1, 'b': 2}
434 y = {'a': 2, 'b': 3}434 y = {'a': 2, 'b': 3}
435 self.assertThat(a, KeysEqual(b))435 self.assertThat(x, KeysEqual(y))
436436
437437
438MatchesRegex438MatchesRegex
439439
=== modified file 'testtools/run.py'
--- testtools/run.py 2012-10-17 22:38:13 +0000
+++ testtools/run.py 2012-11-29 11:44:24 +0000
@@ -307,7 +307,7 @@
307 and getattr(unittest, 'installHandler', None) is not None):307 and getattr(unittest, 'installHandler', None) is not None):
308 unittest.installHandler()308 unittest.installHandler()
309 if self.testRunner is None:309 if self.testRunner is None:
310 self.testRunner = runner.TextTestRunner310 self.testRunner = TestToolsTestRunner(sys.stdout)
311 if isinstance(self.testRunner, classtypes()):311 if isinstance(self.testRunner, classtypes()):
312 try:312 try:
313 testRunner = self.testRunner(verbosity=self.verbosity,313 testRunner = self.testRunner(verbosity=self.verbosity,

Subscribers

People subscribed via source and target branches