Code review comment for lp:~vila/otto/update-setup-instructions

On 10/30/2013 09:37 AM, Vincent Ladeuil wrote:
>> This configuration is required in production to keep control of the machines if a test goes crazy.
>
> Why the swap part though ? Just setting a memory limit should be enough no ?
Because it happened that the machine used swap because there was not
enough RAM (run unity7 testsuite with recordmydesktop enabled with
default settings twice and the machine will crash)

FTR, recordmydesktop (+the way autopilot uses it?) causes memory
fragmentation which leads to memory exhaustion and sometimes requiring
swap to finish the test.

>
>> Why do you do
>> $ sudo ln -s /etc/apparmor.d/usr.bin.rsyslogd /etc/apparmor.d/disable/
>> ?
>
> I found it on dx-autopilot-intel, dx-autopilot-nvidia, dx-autopilot-ati, ps-nvidia-gt630, ps-intel-4600, ps-radeon-hd8350, qa-nvidia-gtx660 and qa-intel-4000. So I thought it was required.
>
> If it's not, I'd rather remove it both in that doc and in the ci lab.
>
>> There is a typo line 63 (missing semicolon or new line).
>
> Good catch, fixed.
>

--
Jean-Baptiste
IRC: jibel