Code review comment for lp:~vila/otto/update-setup-instructions

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Vincent for your efforts to document that better. I recently re-tried otto myself on saucy/trusty and it was certainly far harder than necessary.

> 1) swapaccount: I wasn't able to verify that the CONFIG_MEMCG_SWAP_ENABLED was set in the kernel config:

That's indeed the biggest pain point right now. At least saucy/trusty indeed don't set this in the default kernel config, so otto does not work at all out of the box. I think that should be addressed in the code, not in the documentation. My current workaround is this:

--- lxc.defaults/config 2013-07-05 21:00:06 +0000
+++ lxc.defaults/config 2013-10-17 14:22:47 +0000
@@ -67,5 +67,5 @@
 lxc.loglevel = 1

 # Restrict memory usage of the container
-lxc.cgroup.memory.limit_in_bytes = 2G
-lxc.cgroup.memory.memsw.limit_in_bytes = 2560M
+#lxc.cgroup.memory.limit_in_bytes = 2G
+#lxc.cgroup.memory.memsw.limit_in_bytes = 2560M

But I think otto should dynamically enable that feature if the kernel supports it.

+ * branch otto from launchpad and setup a ~/bin directory

I think this should become a separate documentation item, as it is optional. Like:

  * If you don't want to call otto with full path of the checkout, you can put it into $PATH with:

    mkdir -p ~/bin
    for f in `pwd`/otto/bin/*; do ln -s $f ~/bin; done

« Back to merge proposal