Code review comment for lp:~vila/bzr/tree-has-changes

Revision history for this message
Robert Collins (lifeless) wrote :

On Thu, 2009-07-02 at 17:00 +0000, John A Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1

> Do we want to do this as:
>
> wt.has_changes(other_tree)
>
> or do we want it as simply
>
> wt.has_changes()

I don't have a strong opinion; if I were deciding I would look at where
it is used: if it is used in operations that take -r parameters, then
the former is probably correct. If its only ever desirable to know if
there are changes without examining them then doing it just on mutable
tree seems ok to me.

-Rob

« Back to merge proposal