Code review comment for lp:~vila/bzr/missing-stacks

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/17/2011 6:20 PM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/missing-stacks
> into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core)
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/missing-stacks/+merge/71918
>
> One store was missing for the stealth 'control.conf'.
>
> This patch adds it as well as the missing stacks:
>
> - control.conf gets its own stack as it seems to me it needs to be
> used in isolation (it contains only default_stacked_on anyway),
>
> - remote branches needs a special stack because they ignore
> bazaar.conf and locations.conf (both locally and remotely).

How do you mean they ignore bazaar.conf and locations.conf? I've
certainly set

 [bzr+ssh://host/path/to/branch]
 public_location = http://host/branch

In the past. That may not be working now, or whatever. But since
locations.conf exists to be able to override configuration settings
for remote branches, explicitly ignoring them seems really odd.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5Ux2oACgkQJdeBCYSNAAOyGgCeNviSyq0Zn3D0RV3m8tbiRUnV
500An08s/B80abXa55iv32zZ7NE7ILk9
=2d+D
-----END PGP SIGNATURE-----