Code review comment for lp:~vila/bzr/leaking-tests-catch-them-all

Revision history for this message
Martin Packman (gz) wrote :

I'm getting over a hundred errors with this branch in my test setup in the form:

    Traceback (most recent call last):
      ...
      File ".\bzrlib\bundle\__init__.py", line 42, in read_mergeable_from_url
        possible_transports=possible_transports)
      File ".\bzrlib\tests\__init__.py", line 2441, in get_transport_with_cleanup
        t = self._orig_get_transport(*args, **kwargs)
    AttributeError: 'TestBoundBranches' object has no attribute '_orig_get_transport'

This is because I'm clearing the TestCase __dict__ in the result's stopTest method, so is this method being run after that? Or on the wrong test instance? Something seems up, at any rate.

On the plus side, the run does now complete without hanging which earlier versions of this branch did not. However, it seems to have taken 83 minutes, rather than ~50 which is what I'm getting currently on trunk.

« Back to merge proposal