> ^- [comment] changing the 'self' parameter to not be self seems
> confusing. I think I preferred your form using:
>
> test = self
>
>
> Or even better would be to pass 'self' to the
> FailingDuringResponseHandler's __init__ constructor, and saving it as
> an attribute. This particular change will conflict landing on bzr.dev,
> but should be obvious to fix.
I agree with John, passing in or setting a temporary class attribute is neater.
His other points sound good too, but PQM needs feeding so will try landing this and see what falls out.
> ^- [comment] changing the 'self' parameter to not be self seems sponseHandler' s __init__ constructor, and saving it as
> confusing. I think I preferred your form using:
>
> test = self
>
>
> Or even better would be to pass 'self' to the
> FailingDuringRe
> an attribute. This particular change will conflict landing on bzr.dev,
> but should be obvious to fix.
I agree with John, passing in or setting a temporary class attribute is neater.
His other points sound good too, but PQM needs feeding so will try landing this and see what falls out.