Code review comment for lp:~vila/bzr/856261-unshelve-line-based

> I also ran into problems using shelve with my VIM plugin.

WOW ! (And that's coming from die-hard emacs user ;-D)

> Other commands
> use ui.get_boolean, but there is no corresponding method for handling
> more complex choices. So even after providing my own UI class
> implementation, I cannot use shelve.
>
> In VIM there is a confirm function:
>
> confirm({msg} [, {choices} [, {default} [, {type}]]])
>
> Which can be used like this:
>
> confirm("Save changes?", "&Yes\n&No\n&Cancel")
>
> Where the letter after the '&' is the shortcut key for that choice.
>
> So I have been working on a branch to implement something just like
> this (see attached patch).

This sounds *seriously* interesting and I urge you to pusblish your changes
in a branch and propose it for merge so we can properly review it (I'm
pleased tht launchpad displays your patch inline ! Wow too there) but I
really want your patch to be discussed as it seems we have perfect case of
triangulation here ;)

>
> N.B.: your patch removes a call to gettext.

Ouch, yeah, I initially wrote the patch on a 2.4-based branch where the
gettext call wasn't there >-/ I'll push a revision fixing that asap. Thanks
catching it !