Code review comment for lp:~vila/bzr/822649-bsd-no-fdatasync

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/8/2011 2:52 PM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging
> lp:~vila/bzr/822649-bsd-no-fdatasync into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #822649 in
> Bazaar:
> "bzrlib.tests.test_transport.TestLocalTransportWriteStream.test_local_fdatasync_calls_fdatasync
> fails on BSDs" https://bugs.launchpad.net/bzr/+bug/822649
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/822649-bsd-no-fdatasync/+merge/70733
>
> Don't try to run the test if os.fdatasync is not defined.

I should also mention that the test could proceed and make sure the
system doesn't crash if fdatasync doesn't exist. (Though that could be a
separate test that forcibly removes fdatasync always.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4/4KkACgkQJdeBCYSNAAO9sQCfZpPZU6m73z/M+UBw4ecIYUJb
BQ4An0rFmOsHnygZmOMC4u1zEUV6e8it
=1BBM
-----END PGP SIGNATURE-----