Code review comment for lp:~vila/bzr/822649-bsd-no-fdatasync

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/8/2011 2:52 PM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging
> lp:~vila/bzr/822649-bsd-no-fdatasync into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #822649 in
> Bazaar:
> "bzrlib.tests.test_transport.TestLocalTransportWriteStream.test_local_fdatasync_calls_fdatasync
> fails on BSDs" https://bugs.launchpad.net/bzr/+bug/822649
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/822649-bsd-no-fdatasync/+merge/70733
>
> Don't try to run the test if os.fdatasync is not defined.

I'm wondering if it would be better to just teach 'overrideAttr' to not
fail when the target attribute doesn't exist. Otherwise:

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4/4HUACgkQJdeBCYSNAAPeygCcDUXlrm5BK5t1UW5Yih56Baf6
gswAn3ip+MnVQY8SIFVny+04v/EngA5A
=CGJq
-----END PGP SIGNATURE-----