Code review comment for lp:~vila/bzr/788530-better-invalid-http-response
Revision history for this message
| Martin Packman (gz) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Good change. Really bzrlib.errors could do with a uniform idiom for including wrapped errors as a number of exception classes want to do it.
+ orig_error = ': %r' % (orig_error,)
This is fine in Python 2.5 and later where the repr generally includes the details you care about, in 2.4 most exceptions just have object.__repr__ which is less useful. The nice thing about %r over %s is it avoids the bug with localised error messages with non-ascii characters.