Code review comment for lp:~vila/bzr/783472-wt-scenarios

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/16/2011 03:42 PM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/783472-wt-scenarios into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> Bug #783472 in Bazaar: "per_working_tree should provide reusable scenarios"
> https://bugs.launchpad.net/bzr/+bug/783472
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/783472-wt-scenarios/+merge/61117
>
> I used to use wt_scenarios in per_workingtree in one of my plugins.
>
> This disappeared recently (the helper wasn't particularly well documented to be honest) and I didn't realize that until recently.
>
> This mp re-introduce the helper.
>
> As mentioned in the bug, this another valid use case to reuse tests and it would be nice to keep it in mind for our other parameterized tests (I don't intend to fix that pro-actively though).

I'm fine re-introducing this. But if you actually depend on it
externally, it sounds like something that needs a test case so that we
don't delete it without letting people know.

John
=:->

 review:needsfixing

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3RMCIACgkQJdeBCYSNAAOapACfTfwK7UE4Qbk2cjJ3ccUOMBWh
PqgAoJi46jYJ5MjYSOkPz09PD7ADng75
=UcnS
-----END PGP SIGNATURE-----