Code review comment for lp:~vila/bzr/782289-chm-sphinx

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> John Arbash Meinel <email address hidden> writes:

    > ...
    >> > I'm not quite understand this change.
    >>
    >> The file was named readme.txt, all generated files there are named
    >> '.txt'. Trying to trigger a minimal rebuild I deleted some and then all
    >> files there without realizing that this 'readme.txt' wasn't a generated
    >> one.
    >>
    >> Renaming it README (all caps *and* no suffix) should avoid such a
    >> mistake in the future.

    > The fact that "bzr status" tells you seems sufficient to me.

You miss the point.

I realized my mistake *only* when doing 'bzr diff' and seeing the
content of the readme.txt.

Only then did I realized my mistake.

If it has been called README to start with, I would have notice it
earlier and be put on track faster.

You can still open a README file on windows with a
double-click... you're proposed with applications that can open it.

« Back to merge proposal