Code review comment for lp:~vila/bzr/782289-chm-sphinx

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> Alexander Belchenko writes:

<snip/>

    >> Restore the workaround to avoid sphinx errors with dotted format names (--1.14).

    > I'd like to have this fix backported to 2.3.

Should be pretty straight-forward, but is it necessary ? Did we already
remove --1.9 in 2.3 ?

    >> Rename readme.txt into README to avoid accidental deletion (I
    >> deleted all the '.txt' files there while trying to find which
    >> code where generating the files...)

    > I'm not quite understand this change.

The file was named readme.txt, all generated files there are named
'.txt'. Trying to trigger a minimal rebuild I deleted some and then all
files there without realizing that this 'readme.txt' wasn't a generated
one.

Renaming it README (all caps *and* no suffix) should avoid such a
mistake in the future.

    > There are some ReST problems with japanese texts, it should be
    > easy to fix too.

File a bug please, I don't speak Japanese and last time I looked into
this one I wasn't sure my font was correctly displaying the glyphs so I
didn't want to mess with it.

I heard a rumor that we have some Japanese hacker around working on
i18n, this may be obvious for him ;)

« Back to merge proposal