Code review comment for lp:~vila/bzr/781140-ftp-test-coverage

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/7/2011 9:18 AM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/781140-ftp-test-coverage into lp:bzr.

...

> Note that the medusa plumbing was removed when we made python-2.6
> a requirement. I had to dig a bit to find it back and I like to
> keep it disabled (instead of removed) to make it easier to use it
> again. An alternative would be fully purge the test framework
> from all medusa references but that's more work for little
> benefits. Roughly, we try to import and disable support, less
> trouble than digging the history.
>
> This patch needs to land before we can deploy pyftpdlib again, be
> it on babune or pqm or both.

+if pyftplib_version < (0, 6,0):

Spacing is wrong on this one.

Otherwise:
 merge: approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3t3MQACgkQJdeBCYSNAAP4vACcDqu5EqBCzq0ZnJki9+zh1dFf
Kp0AoJuuQXKx3Ez4Ni2KlAJ7TvPlYb+c
=Ig3r
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal