Code review comment for lp:~vila/bzr/712474-module-available

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/16/2011 4:21 PM, Vincent Ladeuil wrote:
> You have been requested to review the proposed merge of
> lp:~vila/bzr/712474-module-available into lp:bzr.
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/712474-module-available/+merge/48474
>
> __import__ doesn't check that a module has already been imported,
> don't use it.
>
> See the bug report for a real life use case (bzr-svn plugin).
>
>

Your cover letter is a bit incorrect. You're still using "__import__"
you're just guarding it with a check that the module isn't already imported.

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5KgpwACgkQJdeBCYSNAAN9OgCeIiAvxAQ57XRprJEOikfhFbff
4akAniys+2FQugggnC0uV2pLm4ISxJYQ
=Sf+E
-----END PGP SIGNATURE-----