Merge lp:~vila/bzr/687315-lazr-uri into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Rejected |
---|---|
Rejected by: | Vincent Ladeuil |
Proposed branch: | lp:~vila/bzr/687315-lazr-uri |
Merge into: | lp:bzr |
Diff against target: |
44 lines (+10/-2) 2 files modified
bzrlib/plugins/launchpad/test_lp_api.py (+7/-2) doc/en/release-notes/bzr-2.3.txt (+3/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/687315-lazr-uri |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+43079@code.launchpad.net |
Commit message
Tests requiring lazr.uri should check for its presence
Description of the change
Some test from the launchpad plugins rightly check for the
launchpadlib presence or are skipped.
Some of them still fail if some launchpadlib dependencies are not
present, namely lazr.uri.
This fixes bug #687315 by adding a lazr.uri test feature and uses
it where appropriate.
To post a comment you must log in.
Unmerged revisions
- 5564. By Vincent Ladeuil
-
Tests requiring lazr.uri should check for its presence
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/8/2010 7:40 AM, Vincent Ladeuil wrote: /bugs.launchpad .net/bugs/ 687315
> Vincent Ladeuil has proposed merging lp:~vila/bzr/687315-lazr-uri into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #687315 some tests from the launchpad plugin requires lazr.uri
> https:/
>
>
> Some test from the launchpad plugins rightly check for the
> launchpadlib presence or are skipped.
>
> Some of them still fail if some launchpadlib dependencies are not
> present, namely lazr.uri.
>
> This fixes bug #687315 by adding a lazr.uri test feature and uses
> it where appropriate.
merge: approve
I would have thought you couldn't install launchpadlib without its
dependencies, but no big deal.
John enigmail. mozdev. org/
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkz /u88ACgkQJdeBCY SNAANG7ACff2Bk8 YHeFBpuh1Aj4F0x ZSHb nizcVPiBFs6Hs1d 7o
qP4AoJAPN8ZDAAn
=3Dwj
-----END PGP SIGNATURE-----