Code review comment for lp:~vila/bzr/687315-lazr-uri

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/8/2010 7:40 AM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/687315-lazr-uri into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #687315 some tests from the launchpad plugin requires lazr.uri
> https://bugs.launchpad.net/bugs/687315
>
>
> Some test from the launchpad plugins rightly check for the
> launchpadlib presence or are skipped.
>
> Some of them still fail if some launchpadlib dependencies are not
> present, namely lazr.uri.
>
> This fixes bug #687315 by adding a lazr.uri test feature and uses
> it where appropriate.

 merge: approve

I would have thought you couldn't install launchpadlib without its
dependencies, but no big deal.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkz/u88ACgkQJdeBCYSNAANG7ACff2Bk8YHeFBpuh1Aj4F0xZSHb
qP4AoJAPN8ZDAAnnizcVPiBFs6Hs1d7o
=3Dwj
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal