Code review comment for lp:~vila/bzr/673637-temp-commit-file

Revision history for this message
John A Meinel (jameinel) wrote :

I'm "ok" with this fix. It seems to solve a problem that someone was having.

The concerns are:

1) it seems like the problem is actually in emacs, and we are papering around it in bzr
2) It means that you won't use the cwd for staging the commit log, in case someone wants to save it off somewhere for later (in case of failure to commit/rollback/etc.)
3) I don't have any personal stake, because I always use "-m" and shell as my commit message editor. (With the other benefit that 'bzr diff' always continues to work.) As such, I don't have a feel for how this will impact people, since I don't use it.

4) I think this might also solve a bug people were having, where they wanted to commit it /etc, and had rights to /etc/.bzr but *not* rights to /etc/ itself. (sysadmins not wanting to commit as root, I guess.)

On the whole, I think I'm for it, just concerned about possible fallout.

review: Approve

« Back to merge proposal