Code review comment for lp:~vila/bzr/625686-selftest-cleanup-deprecation-warnings

Revision history for this message
Martin Packman (gz) wrote :

Change looks good to me. One thing, I'd prefer if you passed and closed over the warnings.filters list as well as well as the tuple just added, to defend against that module global changing.

The warnings module upsets me a little more every time I go near it...

review: Approve

« Back to merge proposal