Code review comment for lp:~vila/bzr/494221-unversion-children

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/494221-unversion-children into lp:bzr/2.0.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #494221 KeyError in remove_recursive_id during commit
> https://bugs.launchpad.net/bugs/494221
>
>
> This fixes bug #494221, with a test reproducing it.
>
> While working on it with John, we encounter several bugs that made it harder to implement a better fix.
>
> So this fix is minimal and targeted at 2.0 but better fixes will be targeted at trunk.
>
> The issue at hand is that the in-memory inventory needs to be updated if it has already been loaded which occurs more often on windows than on linux.
>
> We probably fixed the original bug on linux long ago so this fix should mostly concern windows.
>

 review: needsfixing

Small tweak. The test should check that the file-ids are actually
removed from the inventory. Otherwise good to merge.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw8P9wACgkQJdeBCYSNAAP7wACfahJWOqloMEIsQUo+CwwKWcgR
fHkAniiNRT/eUPWxmvoteiWdle0DxMpS
=wWQQ
-----END PGP SIGNATURE-----