Code review comment for lp:~vila/bzr/443041-ftp-append-bytes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/443041-ftp-append-bytes into lp:bzr.
>
> Requested reviews:
> John A Meinel (jameinel)
>
>

So as I understand it, the main change is that _create_connection for
the regular ftp server was calling:
             # binary mode is the default
             connection.voidcmd('TYPE I')

And the implementation of the GSSAPI ftp server was not. So you
refactored the code such that only "_login()" is overridden, rather than
all of "_create_connection".

Less code duplication is very nice.

 review: approve
 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrLX5IACgkQJdeBCYSNAANGBgCgyRAkVr0jmG861id48+LGlRqe
IyUAn0xCfFiFsT6JT0Cuv+Hy9u50TaEd
=X5qe
-----END PGP SIGNATURE-----