Merge lp:~vila/bzr/385453-make-pyrex into lp:~bzr/bzr/trunk-old
Status: | Rejected |
---|---|
Rejected by: | Martin Pool |
Proposed branch: | lp:~vila/bzr/385453-make-pyrex |
Merge into: | lp:~bzr/bzr/trunk-old |
Diff against target: | 286 lines |
To merge this branch: | bzr merge lp:~vila/bzr/385453-make-pyrex |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pool | Needs Fixing | ||
Review via email: mp+7808@code.launchpad.net |
Unmerged revisions
- 4465. By Vincent Ladeuil
-
Rough fix for bug#385453.
* setup.py:
Some cleanup and exit early if pyrex generated C files are not
available.* bzrlib/
tests/test_ setup.py:
(TestSetup.setUp): CleanupBetter protect the build dir.
(TestSetupBuild): Start adding tests for the build step.
(TestSetupInstall): Separate install step tests.* bzrlib/
tests/_ _init__ .py:
(PyrexFeature): Most extensions use pyrex. - 4464. By Vincent Ladeuil
-
Cleanup setup tests.
* bzrlib/
tests/test_ setup.py:
(TestSetup): Protect the existing build dir.
(TestSetup.test_build_ and_install. rmtree) : Use cleanup hooks and
don't clobber the existing build dir.* .bzrignore:
All pyrex generated files follow the same pattern. - 4463. By Vincent Ladeuil
-
Fixed as per John and Martin reviews.
* bzrlib/
_dirstate_ helpers_ pyx.pyx:
(_cmp_path_by_dirblock_ intern) : Renamed as requested. - 4462. By Vincent Ladeuil
-
Fix failing benchmarks for dirstate helpers.
- 4461. By Vincent Ladeuil
-
Use the same method or function names for _dirstate_helpers in pyrex and
python modules. - 4460. By Vincent Ladeuil
-
Use a consistent scheme for naming pyrex source files.
- 4459. By Canonical.com Patch Queue Manager <email address hidden>
-
(jam) Remove a spurious call to _get_raw_record,
speeds up get_record_stream( ..., True) - 4458. By Canonical.com Patch Queue Manager <email address hidden>
-
(andrew) Fix branch format upgrades triggered by default stacking
policy on a smart server. - 4457. By Canonical.com Patch Queue Manager <email address hidden>
-
(igc) fix ls DIR --from-root and improve ls performance
- 4456. By Canonical.com Patch Queue Manager <email address hidden>
-
(jam) Fix some failing tests on win32
So this implements a simple-minded fix for the bug.
The idea is that setup.py is used, so far, to either build extensions or build the distribution which should always include the extensions anyway.
In short, setup is useless if you don't have pyrex or if you don't have the C files.
So the implemented fix make setup abort if pyrex is not available *and* the C files are not available.
It also starts implementing tests for that.
As discussed with Martin and John, splitting the build step into generation and compilation and
archiving the post-processed generated files can come later.