Code review comment for lp:~vila/bzr/353370-notty-no-term-width

>>>>> "martin" == Martin Pool <email address hidden> writes:

    martin> Review: Disapprove

    martin> Sorry but I really think truncating to any width when
    martin> there's no terminal to truncate for is bogus.

I would have appreciated a bit more depth for that review (I've been
acting as patch pilot before the initiative was started so I'm not the
original author of the patch).

The case at point is not to truncate when there is no terminal, it is
that bzr want to right-justify when there is no terminal, without
terminal it's hard to derive a width and without width you can't
right-justify.

That's why I said several times that a deeper fix is needed *in the
callers* (the so-called "filling" cases, corrections welcome if it's
unclear) and that's where I was expecting your input.

    martin> If we are going to do it, better to do it at 80 so that it's
    martin> obvious, rather than sweeping it under the carpet.

That's definitely not a progress since that doesn't give any way to get
full test names for example.

    martin> If you want progress for non-tty output I'd rather look at
    martin> restoring something like the 'dots' progress bar.

Irrelevant. Having the name of the test output when the test start is
far enough, having the ability to display the *full* name is what I was
after, but only as an additional bonus.