Code review comment for lp:~vila/bzr/321320-isolate-doc-tests

Revision history for this message
Vincent Ladeuil (vila) wrote :

> This may as well land if it fixes the problems with doctests people are
> actually having, even if it's not a complete solution.

Ok.

>
> Anyone with for instance, a plugin that adds a hook and doesn't run selftest
> with --no-plugins will still risk random behaviour though right?

Right.

> I'd like a
> note in the developer documentation saying doctests are not as robustly
> isolated as general tests.

Ok.

> Do you also want to uncomment the doctest we disabled the other day in this
> branch?

I did and used it to ensure my fix addressed the related problem.

« Back to merge proposal