Code review comment for lp:~vila/bzr/321320-isolate-doc-tests

Revision history for this message
Andrew Bennetts (spiv) wrote :

My suspicion was right: this branch does not appear to fix 321320, except sometimes by accident.

If you e.g. run 'bzr selftest' from your home dir, HOME is set to your real home, and config values in your normal ~/.bazaar/bazaar.conf like create_signatures take effect. In my case that cases gnome-gpg to be run for every commit the test suite does. At best that will slow down the tests considerably, at worst cause test hangs or test failures. This case definitely ought to work, and if bug 321320 is properly fixed, it would.

review: Needs Fixing

« Back to merge proposal