Code review comment for lp:~vila/bzr/316357-SIGWINCH

Revision history for this message
Martin Pool (mbp) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 vote needs-fixing

Aside from Martin.gz's comment it looks reasonable to me.

> Changes to the console window size are communicated using WINDOW_BUFFER_SIZE_RECORD from ReadConsoleInput, which isn't in the bazaar loop currently.

Maybe on Windows we should just call _win32_terminal_size every time
we want to know?

- - --
Martin <http://launchpad.net/~mbp/>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAksnQd8ACgkQPGPKP6Cz6It9uQCfTkNUg4vS6Pi4DogMGgjy7OBZ
MUsAn3bd9NBHDMRYk4GTXTwMx/llmE48
=doaZ
-----END PGP SIGNATURE-----

review: Needs Fixing

« Back to merge proposal