Code review comment for lp:~vila/bzr/284038-push-strict

>>>>> "jam" == John A Meinel <email address hidden> writes:

<snip/>

    jam> Also...

    jam> We should *definitely* be checking:

    jam> tree.last_revision() == tree.branch.last_revision()

    jam> And possibly consider what to do in the case of bound
    jam> branches and heavyweight checkouts. I'm not *as*
    jam> concerned about the latter, but because in the former
    jam> case, IIRC we will actually be pushing
    jam> "tree.branch.last_revision()" *not*
    jam> tree.last_revision()...

Hmm, so far --strict is defined as triggering if there are
*uncommitted* changes, you're stretching the definition here...

    jam> So certainly '--strict' should fail if the tree and
    jam> branch aren't at the same rev.

I'm not sure I agree with you (nor that I disagree), but I think
that's worth filing a different bug.

       Vincent