Code review comment for lp:~vila/bzr/284038-push-strict

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/284038-push-strict into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> This complements my first attempt to fix the bug while also fixing bugs #322808 and #65286,
> by making --strict defaults to true.
>
> Changing the default value revealed a bug in the previous implementation as push can be used without
> a working tree.
>
> Also the --strict option is meaningless if the --revision option is used.
>
> Previous reviews mentioned introducing:
> - a way to query config files for a bool option,
> - a new method on working tree for checking changes.
>
> Since both are also needed for bug #206577, I'd like to postpone these modifications until both fixes
> have landed.
>

Also...

We should *definitely* be checking:

 tree.last_revision() == tree.branch.last_revision()

And possibly consider what to do in the case of bound branches and
heavyweight checkouts.
I'm not *as* concerned about the latter, but because in the former case,
IIRC we will actually be pushing "tree.branch.last_revision()" *not*
tree.last_revision()...

So certainly '--strict' should fail if the tree and branch aren't at the
same rev.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpIxUIACgkQJdeBCYSNAAPc/wCfVTwT8aIl1QBDg4ho7rv/C1zI
3e4AniMO3HZD1SgHyMKOAG0uXZY0qs2g
=Qf45
-----END PGP SIGNATURE-----