Merge lp:~vila/bzr/1509156-stricter-readonly into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | Vincent Ladeuil |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6612 |
Proposed branch: | lp:~vila/bzr/1509156-stricter-readonly |
Merge into: | lp:bzr |
Diff against target: |
137 lines (+40/-7) 4 files modified
bzrlib/tests/per_transport.py (+10/-3) bzrlib/tests/test_smart_transport.py (+16/-1) bzrlib/transport/readonly.py (+11/-3) doc/en/release-notes/bzr-2.7.txt (+3/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/1509156-stricter-readonly |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Wilbur | Approve | ||
Review via email: mp+283512@code.launchpad.net |
This proposal supersedes a proposal from 2016-01-21.
Commit message
Forbid more operations on ReadonlyTranspo
Description of the change
This fixes bug #1509156 by forbidding rename() and open_write_stream() to be called on a transport decorated with ReadonlyTranspo
This ensures such transports can't be misused but so far they only allowed renaming existing files.
So this fix mostly closes the remaining holes but doesn't change the intent of the decorator.
To post a comment you must log in.
I think this is a great idea, Vincent. 9 hours after you made the merge proposal, the diff still doesn't show! ("Updating diff...
An updated diff will be available in a few minutes. Reload to see the changes.")
Sounds like something is stuck. I don't know that approving it will be sufficient to merge it at this point when it is confused about the changes.