Code review comment for lp:~vila/bzr/1195783-platform-utf8

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-07-14 2:41, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging
> lp:~vila/bzr/1195783-platform-utf8 into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #1195783
> in Bazaar: "UnicodeDecodeError from bzr version if platform
> contains non-ASCII" https://bugs.launchpad.net/bzr/+bug/1195783
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/1195783-platform-utf8/+merge/174591
>
> This fixes http://pad.lv/1195783 by considering that platform
> names are utf8 encoded (see discussion on the bug report).
>

Do we want to add a test that we do a best-effort on names that aren't
actually utf-8 but aren't ascii either? (The normal we did was utf8,
iso-8859-1, but I would be fine with just decode(, 'replace') here).

 review: approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlHiY44ACgkQJdeBCYSNAANRmQCgxZnGbdMhdSGYSFD0ZH3PkHHi
gnkAniIcFz8JPGbsRhD8gDgP5nblMASG
=q2dl
-----END PGP SIGNATURE-----