Code review comment for lp:~vila/bzr/1086209-lc-all-c

John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-12-04 18:29, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr/1086209-lc-all-c
> into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #1086209
> in Bazaar: "test failures in bzr.dev when run with LC_ALL=C"
> https://bugs.launchpad.net/bzr/+bug/1086209
>
> For more details, see:
> https://code.launchpad.net/~vila/bzr/1086209-lc-all-c/+merge/137862
>
> This should fix the LC_ALL=C test failures.
>
> It's a bit weird that we didn't try to use the self.stderr encoding
> so I went with a conservative fix: if something bad happens, we'll
> fall back to the previous implementation.
>

+* Fix test failures occurring only with LC_ALL=C, when prompting a user,
+ ``stdee`` encoding should be preferred over terminal encoding if
+ available. (Vincent Ladeuil, #1086209)

tyop

Otherwise:
 review: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlC+HCMACgkQJdeBCYSNAAP4dACfd6iuMu3YbSn+ICQMQKKZqs2L
JZUAn0iYiaxAE1q0Z0r4W1dAVkHwODx+
=lqmC
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal