Code review comment for lp:~vila/autopilot/timestamped-subunit-stream

Revision history for this message
Christopher Lee (veebers) wrote :

Hi Vincent,

autopilot/tests/unit/test_testresults.py seems like a decent place to put the tests.

Regarding running the tests, which WM/DM are you running out of interest? It seems there may be an assumption the tests are making that is causing this to happen.

I ran some tests with trunk and this branch and compared the results of using 'subunit-ls --times'.

I saw similar results on both runs (the trunk version has some times) perhaps I'm missing something?

Also, I ran some functional tests (so they take a little longer per test) and found that when using this branch every result was 0.000 seconds (even though I was watching them run and they totally took longer than that) where the trunk run had times for each test. Perhaps I'm doing something wrong?

Commands I used:
  $ python3 -m autopilot.run run -v -o /tmp/subunit-output-vila.subunit -f subunit autopilot.tests.functional.test_input_stack

  $ subunit-ls --times /tmp/subunit-output-vila.subunit

The output along the lines of:
autopilot.tests.functional.test_input_stack.InputStackKeyboardTypingTests.test_text_typing(UInput,lower_alpha) 0.000
autopilot.tests.functional.test_input_stack.InputStackKeyboardTypingTests.test_text_typing(UInput,upper_alpha) 0.000
autopilot.tests.functional.test_input_stack.InputStackKeyboardTypingTests.test_text_typing(UInput,numeric) 0.000
autopilot.tests.functional.test_input_stack.InputStackKeyboardTypingTests.test_text_typing(UInput,punctuation) 0.000

review: Needs Information

« Back to merge proposal