Code review comment for lp:~vikoadi/pantheon-greeter/manage-screensaver

Revision history for this message
Raphael Isemann (teemperor) wrote :

Yeah accessing gsettings from other users is the big problem with the
greeter. Only clean way is to extend accountsservices (which is a PITA).
Am 15.12.2014 03:43 schrieb "Viko Adi Rahmawan" <email address hidden>:

> > Soooooooo when does this take effect? At the lock screen or in the normal
> > pantheon session?
> This only handle timeout in Pantheon greeter. it will have no effect in
> normal mode.
>
> the "startup " i meant at description of change is pantheon-greeter's
> startup
>
> > Like if I just leave my computer without locking it the
> > screen turns off after 60 seconds?
>
> No
>
> > Or if the computer is locked then after 60
> > seconds the screen turns off? Or both?
>
> only turn off the screen on locker
>
> after testing i still found something which doesnt work like i supposed it
> to:
> * it can't get user gsetting's timeout, only the system default. so i
> can't change from 60 seconds timeout.
> * saving and restoring normal timeout is still hit and miss
> --
>
> https://code.launchpad.net/~vikoadi/pantheon-greeter/manage-screensaver/+merge/244680
> Your team elementary Pantheon team is requested to review the proposed
> merge of lp:~vikoadi/pantheon-greeter/manage-screensaver into
> lp:pantheon-greeter.
>

« Back to merge proposal