Code review comment for lp:~vikoadi/pantheon-files/fix-1041633
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
I can't tell from the code if it deletes the thumbnail on every file change. If so, we've tried that approach already and gave up on it because it yeilds 100% CPU load on continuously written files (e.g. large downloads).
Instead, inotify provides a "close_write" event, which is emitted when *closing* a file that was written to. Please use such an event instead.