Code review comment for lp:~victored/wingpanel/lp-1380392
Revision history for this message
| Victor Martinez (victored) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks for the review Carl.
Addressing your concerns:
1) Without this branch, if you click on the network indicator, disable the network, and then re-enable it, the arrow is permanently pointing to the wrong indicator until wingpanel is restarted. This branch addresses that issue. When the menu shrinks the arrow is properly updated and points in the correct direction.
If by properly you mean that the arrow might be misaligned while the menu resizes, that is correct, and it's actually caused by (2). I'm not addressing that in this branch.
2) Wingpanel only controls the drawing of a popover background beneath a transparent menu background. The positioning of the menus is controlled by GtkMenuBar, and it's glitchy. Since there's no clean way to override that, we'd have to write our own menubar implementation and control Gtk.Menu.popup ourselves in order to override the default positioning. This bug is still reproduceable even if you removed all the popover-related modifications performed by the panel. I might implement that at some point, although this fix makes the situation more bearable.