Merge ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1886911/fix-build-against-v5.4/bionic into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/bionic

Proposed by You-Sheng Yang
Status: Merged
Approved by: Timo Aaltonen
Approved revision: 75f1df30493844a55251fe34214a6e60ba0d83aa
Merged at revision: 45f6be66bba0c852f9f42285edaa5930aa0b80aa
Proposed branch: ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1886911/fix-build-against-v5.4/bionic
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/bionic
Diff against target: 114 lines (+86/-0)
4 files modified
debian/changelog (+6/-0)
debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch (+40/-0)
debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch (+38/-0)
debian/patches/series (+2/-0)
Reviewer Review Type Date Requested Status
Timo Aaltonen Approve
Review via email: mp+387100@code.launchpad.net

Commit message

* Fix build against v5.4 kernel (LP: #1886911)

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
Timo Aaltonen (tjaalton) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 3c55ac2..aad2f3d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
1backport-iwlwifi-dkms (7906-0ubuntu4~18.04.2) bionic; urgency=medium
2
3 * Fix build against v5.4 kernel (LP: #1886911)
4
5 -- You-Sheng Yang <vicamo.yang@canonical.com> Thu, 09 Jul 2020 14:37:35 +0800
6
1backport-iwlwifi-dkms (7906-0ubuntu4~18.04.1) bionic; urgency=medium7backport-iwlwifi-dkms (7906-0ubuntu4~18.04.1) bionic; urgency=medium
28
3 * debian/backport-iwlwifi-dkms.dkms.in9 * debian/backport-iwlwifi-dkms.dkms.in
diff --git a/debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch b/debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch
4new file mode 10064410new file mode 100644
index 0000000..96f97bf
--- /dev/null
+++ b/debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch
@@ -0,0 +1,40 @@
1From b9c7458842dc63ab7096385b824c522dba0f5325 Mon Sep 17 00:00:00 2001
2From: Luca Coelho <luciano.coelho@intel.com>
3Date: Tue, 12 Nov 2019 17:28:49 +0200
4Subject: [PATCH 1/2] backport: add pci-aspm.h to backport pci.h
5
6In kernel v5.4, the definitions in pci-aspm.h were moved to pci.h.
7Include pci-aspm.h in the backport pci.h for older kernels.
8
9type=maint
10ticket=none
11
12Change-Id: I82359fa0401d55e312d8bf44661dab274c584678
13Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
14Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/243629
15Tested-by: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@INTEL.COM>
16x-iwlwifi-stack-dev: 3117c57f00bebcecd5ebe3421ba8b34d703cda5a
17(backported from commit 7c0210bec6c0380ab7c136a344ed73b8ddbac264)
18Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
19---
20 backport-include/linux/pci.h | 4 ++++
21 1 file changed, 4 insertions(+)
22
23diff --git a/backport-include/linux/pci.h b/backport-include/linux/pci.h
24index 341660ba6..688680d0e 100644
25--- a/backport-include/linux/pci.h
26+++ b/backport-include/linux/pci.h
27@@ -3,6 +3,10 @@
28 #include_next <linux/pci.h>
29 #include <linux/version.h>
30
31+#if LINUX_VERSION_IS_LESS(5,4,0)
32+#include <linux/pci-aspm.h>
33+#endif
34+
35 #ifndef module_pci_driver
36 /**
37 * module_pci_driver() - Helper macro for registering a PCI driver
38--
392.27.0
40
diff --git a/debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch b/debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch
0new file mode 10064441new file mode 100644
index 0000000..b4559c1
--- /dev/null
+++ b/debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch
@@ -0,0 +1,38 @@
1From 847c79350326aecc8ae78e9816481b650547112d Mon Sep 17 00:00:00 2001
2From: Luca Coelho <luciano.coelho@intel.com>
3Date: Tue, 12 Nov 2019 17:30:41 +0200
4Subject: [PATCH 2/2] [NOUPSTREAM] iwlwifi: pcie: remove pci-aspm.h include
5
6The definitions in pci-aspm.h were moved to pci.h in v5.4. The change
7in iwlwifi should come with a backport, but until then, remove the
8pci-aspm.h include directly.
9
10type=maint
11ticket=none
12
13Change-Id: I6dbb81d77fdc32ee7cd07faa22a9c8b763a315fc
14Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
15Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/243630
16Tested-by: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@INTEL.COM>
17x-iwlwifi-stack-dev: c0f31ab11a74cb303fd4ef1fcd40cc9f13d7337b
18(backported from commit dcb781ec66565326192b43ea34a843bc5606bf59)
19Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
20---
21 drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1 -
22 1 file changed, 1 deletion(-)
23
24diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
25index 519a42142..eb55181a5 100644
26--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
27+++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
28@@ -62,7 +62,6 @@
29 *
30 *****************************************************************************/
31 #include <linux/pci.h>
32-#include <linux/pci-aspm.h>
33 #include <linux/interrupt.h>
34 #include <linux/debugfs.h>
35 #include <linux/sched.h>
36--
372.27.0
38
diff --git a/debian/patches/series b/debian/patches/series
index 7d5bfad..1d24d8f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -5,3 +5,5 @@
50005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch50005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch
60006-NOUPSTREAM-backport-rename-ktime_get_boot_ns-for-v5..patch60006-NOUPSTREAM-backport-rename-ktime_get_boot_ns-for-v5..patch
70006-backport-address-interface-change-in-linux-skbuff.h-.patch70006-backport-address-interface-change-in-linux-skbuff.h-.patch
80007-backport-add-pci-aspm.h-to-backport-pci.h.patch
90008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch

Subscribers

People subscribed via source and target branches