Merge ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1886911/fix-build-against-v5.4/bionic into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/bionic

Proposed by You-Sheng Yang
Status: Merged
Approved by: Timo Aaltonen
Approved revision: 75f1df30493844a55251fe34214a6e60ba0d83aa
Merged at revision: 45f6be66bba0c852f9f42285edaa5930aa0b80aa
Proposed branch: ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1886911/fix-build-against-v5.4/bionic
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/bionic
Diff against target: 114 lines (+86/-0)
4 files modified
debian/changelog (+6/-0)
debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch (+40/-0)
debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch (+38/-0)
debian/patches/series (+2/-0)
Reviewer Review Type Date Requested Status
Timo Aaltonen Approve
Review via email: mp+387100@code.launchpad.net

Commit message

* Fix build against v5.4 kernel (LP: #1886911)

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
Timo Aaltonen (tjaalton) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 3c55ac2..aad2f3d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+backport-iwlwifi-dkms (7906-0ubuntu4~18.04.2) bionic; urgency=medium
7+
8+ * Fix build against v5.4 kernel (LP: #1886911)
9+
10+ -- You-Sheng Yang <vicamo.yang@canonical.com> Thu, 09 Jul 2020 14:37:35 +0800
11+
12 backport-iwlwifi-dkms (7906-0ubuntu4~18.04.1) bionic; urgency=medium
13
14 * debian/backport-iwlwifi-dkms.dkms.in
15diff --git a/debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch b/debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch
16new file mode 100644
17index 0000000..96f97bf
18--- /dev/null
19+++ b/debian/patches/0007-backport-add-pci-aspm.h-to-backport-pci.h.patch
20@@ -0,0 +1,40 @@
21+From b9c7458842dc63ab7096385b824c522dba0f5325 Mon Sep 17 00:00:00 2001
22+From: Luca Coelho <luciano.coelho@intel.com>
23+Date: Tue, 12 Nov 2019 17:28:49 +0200
24+Subject: [PATCH 1/2] backport: add pci-aspm.h to backport pci.h
25+
26+In kernel v5.4, the definitions in pci-aspm.h were moved to pci.h.
27+Include pci-aspm.h in the backport pci.h for older kernels.
28+
29+type=maint
30+ticket=none
31+
32+Change-Id: I82359fa0401d55e312d8bf44661dab274c584678
33+Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
34+Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/243629
35+Tested-by: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@INTEL.COM>
36+x-iwlwifi-stack-dev: 3117c57f00bebcecd5ebe3421ba8b34d703cda5a
37+(backported from commit 7c0210bec6c0380ab7c136a344ed73b8ddbac264)
38+Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
39+---
40+ backport-include/linux/pci.h | 4 ++++
41+ 1 file changed, 4 insertions(+)
42+
43+diff --git a/backport-include/linux/pci.h b/backport-include/linux/pci.h
44+index 341660ba6..688680d0e 100644
45+--- a/backport-include/linux/pci.h
46++++ b/backport-include/linux/pci.h
47+@@ -3,6 +3,10 @@
48+ #include_next <linux/pci.h>
49+ #include <linux/version.h>
50+
51++#if LINUX_VERSION_IS_LESS(5,4,0)
52++#include <linux/pci-aspm.h>
53++#endif
54++
55+ #ifndef module_pci_driver
56+ /**
57+ * module_pci_driver() - Helper macro for registering a PCI driver
58+--
59+2.27.0
60+
61diff --git a/debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch b/debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch
62new file mode 100644
63index 0000000..b4559c1
64--- /dev/null
65+++ b/debian/patches/0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch
66@@ -0,0 +1,38 @@
67+From 847c79350326aecc8ae78e9816481b650547112d Mon Sep 17 00:00:00 2001
68+From: Luca Coelho <luciano.coelho@intel.com>
69+Date: Tue, 12 Nov 2019 17:30:41 +0200
70+Subject: [PATCH 2/2] [NOUPSTREAM] iwlwifi: pcie: remove pci-aspm.h include
71+
72+The definitions in pci-aspm.h were moved to pci.h in v5.4. The change
73+in iwlwifi should come with a backport, but until then, remove the
74+pci-aspm.h include directly.
75+
76+type=maint
77+ticket=none
78+
79+Change-Id: I6dbb81d77fdc32ee7cd07faa22a9c8b763a315fc
80+Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
81+Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/243630
82+Tested-by: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@INTEL.COM>
83+x-iwlwifi-stack-dev: c0f31ab11a74cb303fd4ef1fcd40cc9f13d7337b
84+(backported from commit dcb781ec66565326192b43ea34a843bc5606bf59)
85+Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
86+---
87+ drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1 -
88+ 1 file changed, 1 deletion(-)
89+
90+diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
91+index 519a42142..eb55181a5 100644
92+--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
93++++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
94+@@ -62,7 +62,6 @@
95+ *
96+ *****************************************************************************/
97+ #include <linux/pci.h>
98+-#include <linux/pci-aspm.h>
99+ #include <linux/interrupt.h>
100+ #include <linux/debugfs.h>
101+ #include <linux/sched.h>
102+--
103+2.27.0
104+
105diff --git a/debian/patches/series b/debian/patches/series
106index 7d5bfad..1d24d8f 100644
107--- a/debian/patches/series
108+++ b/debian/patches/series
109@@ -5,3 +5,5 @@
110 0005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch
111 0006-NOUPSTREAM-backport-rename-ktime_get_boot_ns-for-v5..patch
112 0006-backport-address-interface-change-in-linux-skbuff.h-.patch
113+0007-backport-add-pci-aspm.h-to-backport-pci.h.patch
114+0008-NOUPSTREAM-iwlwifi-pcie-remove-pci-aspm.h-include.patch

Subscribers

People subscribed via source and target branches